Looks great to me Dan
1 Like
Hey. Amazing work with this, @Dan
One clarifying question - the cooldown period itself is still until next cycle/round?
And the cooldown applies to the points regardless what dApp you endorse? In your example you specified Cleanify, but the same would apply if a node holder endorses Cleanify with 10 points, then Mugshot with another 10 points, right? For a total of 20 points on cooldown until it expires.
If I’ve understood that correctly then yes, that would work great. No adjustments needed from my end at least. It serves the original intention well.
Hi guys!
the cooldown period itself is still until next cycle/round?
The cooldown period is still counted in rounds, yes. Currently it is set to 1 round, and will remain so after the upgrade. This means that If I endorse APP1 in round 23, I cannot unendorse that app until round 24. But I can still endorse that app (or any other), if I have available points, in round 23.
And the cooldown applies to the points regardless what dApp you endorse?
No, the cooldown is attached to apps.
Eg: I endorse APP1 with 10 points; now I have 10 points in cooldown until the next round. In the same round I endorse APP2 with 10 points, now I have in total 20 points in cooldown until next round.
The example though is easier to understand if we make the cooldown duration 2 rounds:
- I endorse APP1 with 10 points in round 23, and I have 10 points in cooldown for 2 rounds, until round 25.
- In round 24, I decide to endorse another APP2 with 10 points. Now I have in total 20 points in cooldown, of which 10 points will become available in round 25 (the one I used to endorse in point 1) and 10 points will become avaialble in round 26 (that I used to endorse APP2).
2b) If in round 24 I decide to endorse APP1 with an extra 10 points, the cooldown resets, and I will have 20 points blocked for APP1 for another 2 rounds, even if the 10 points I already used to endorse that app with were going to be unlocked in round 25. Basically every time you endorse an app it will reset the cooldown for ALL the points assigned to that app.
One thing that changes is that previously the cooldown was per-node (not per-app) and applied to BOTH endorse and unendorse actions: Are you endorsing an app with this node? Cooldown for a round. Are you unendorsing this app? Cooldown for a week.
While with this refactor the cooldown is applied ONLY WHEN ENDORSING.
This is actually a deliberate design change since a node can now endorse multiple apps, blocking ALL endorsement actions on a cooldown would be overly restrictive, and technically not very scalable and complicated.
2 Likes
I am fully aligned with your solution. A neat workaround to track points without actually tracking them individually and keeps our original proposals goals intact.
1 Like
Dan,
Thanks so much for figuring this out. At this point, we’re all in agreement, so you can move ahead with your plan.
1 Like
Thanks! Yeah, your description is how I thought it would work but rereading my question it was a bit vague. Thanks for the clarification!
No concerns on my end. Looking forward to seeing this live! Great work again
1 Like
Ehy guys, just a heads up saying the UI/UX is sick 
You’ll love this. Hope to be able to release the feature around the end of the next week, will keep you posted.
5 Likes
Cant wait! Sounds amazing
1 Like
Thanks for implementing this much-needed change. Endorsement is becoming an issue, as it feels like there’s no one left with spare endorsement points who is keeping up with what’s happening in the DAO.
2 Likes
don’t get us all excited!!!
1 Like
Proposal executed!
1 Like